-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable and update endpoint for telemetry for longevity tests #2824
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2824 +/- ##
=======================================
Coverage 89.86% 89.86%
=======================================
Files 107 107
Lines 10997 10997
Branches 50 50
=======================================
Hits 9883 9883
Misses 1054 1054
Partials 60 60 ☔ View full report in Codecov by Sentry. |
09b7383
to
9d55657
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll defer to @lucacome to make sure this logic is correct. It looks like we have to enable building with the dev endpoint for all pushes to the release branch in order build the -rc
images with it, which we use for the longevity tests. But this shouldn't be an issue because when we tag
for a release, it'll fail the condition and use the prod endpoint instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test code changes LGTM
1f3c51e
to
18756bc
Compare
18756bc
to
0c92abb
Compare
) Enable and update endpoint for telemetry for longevity tests Problem: Users want to get telemetry reports when running longevity tests to simulate a live environment. Solution: To provide live telemetry reports when running longevity tests, we have enabled telemetry for the test when label is longevity and updated the workflow that creates the binary for release to update the TELEMETRY_ENDPOINT to the dev endpoint.
Proposed changes
We want to report telemetry when running longevity tests to the development endpoint.
Problem: Users want to get telemetry reports when running longevity tests to simulate a live environment.
Solution: To provide live telemetry reports when running longevity tests, we have enabled telemetry for the test when label is
longevity
and updated the workflow that creates the binary for release to update theTELEMETRY_ENDPOINT
to the dev endpoint.Note: I will be updating the binary building workflow to be triggered on a push to release branch. I tested it on the condition of
pull_request
to verify variables are set properly.Testing: Manual testing using Github actions and running longevity tests.
Running
make start-longevity-test
Product Telemetry set to true
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #1781
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.